feat: Allow extension capability keys to contain dot characters #2271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Extend the
ACCEPTED_W3C_PATTERNSfrom^[\\w-]+:.*$to^[\\w-\\.]+:.*$Types of changes
What types of changes are you proposing/introducing to Java client?
Put an
xin the boxes that applyDetails
I'm running an Appium-based test suite in a device cloud. This device cloud has some vendor specific capabilities and I have the option to provide these either with the prefix
digital.aior without any prefix.I used to just use the second option and the following capability statement was no big deal:
{ "accessKey" : "eyJ...k", "appiumVersion" : "2.11.3", "app" : "cloud:my-App-Name", ... }But I have the problem that the second option does not work anymore since a few weeks. The actual capabilities look like this
{ "appium:accessKey" : "eyJ...k", "appium:appiumVersion" : "2.11.3", "app" : "cloud:my-App-Name", ... }And when I switch to the first option by using the vendor-specific key
digital.aiI get this:{ "appium:digital.ai:accessKey" : "eyJ...k", "appium:digital.ai:appiumVersion" : "2.11.3", "app" : "cloud:my-App-Name", ... }leading to the point, that the device cloud cannot find the accessKey for auth.
A
.DOT is not allowed, but a-DASH is. I could not find any restrictions in the spec for this behavior.